Fix tree data update error #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesmeck
force-pushed
the
fix-treeData-update-error
branch
from
36a5b55
to
9cab83b
Compare
|
注意加入缓存是为了提高性能，避免重复计算。可以想想怎么再优化计算性能、再考虑去掉缓存。 |
|
所以不要这么改吗？ |
|
可以这么改。这里改动建议要结合 tree 组件把整个流程理顺、不然容易出 bug ，是刚好看到你改这里，就提一下，没事。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在 treeData 变化后没有去更新 _treeNodesStates 导致 ant-design/ant-design#4084